Fix doubling UI buttons - #6
Open
techgique wants to merge 1 commit into
Open
Conversation
Determine cause to be <ul> elements containing tag tokens They are unintentionally duplicated before and after Annotator controls by code searching for all UL elements in the Annotator editor See in Annotator CoffeeScript: https://github.com/openannotation/annotator/blob/865840ba641c168b24a99af28f390e9778105cea/src/editor.coffee#L267 See in resulting JavaScript: https://github.com/openannotation/annotator/blob/865840ba641c168b24a99af28f390e9778105cea/pkg/annotator.js#L1605 Fix by changing to <ol> elements and updating corresponding CSS Originally fixed here: Willa-Cather-Archive/annotonia@c6b2ba0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Determine cause to be
<ul>elements containing tag tokensThey are unintentionally duplicated before and after Annotator controls
by code searching for all UL elements in the Annotator editor
See in Annotator CoffeeScript:
https://github.com/openannotation/annotator/blob/865840ba641c168b24a99af28f390e9778105cea/src/editor.coffee#L267
See in resulting JavaScript:
https://github.com/openannotation/annotator/blob/865840ba641c168b24a99af28f390e9778105cea/pkg/annotator.js#L1605
Fix by changing to
<ol>elements and updating corresponding CSSOriginally fixed here: Willa-Cather-Archive/annotonia@c6b2ba0