fix: correct CMakeLists.txt variable name typo for Windows DLL bundling#2
Open
imLeGEnDco55 wants to merge 1 commit into
Open
fix: correct CMakeLists.txt variable name typo for Windows DLL bundling#2imLeGEnDco55 wants to merge 1 commit into
imLeGEnDco55 wants to merge 1 commit into
Conversation
The variable `flutter_embedding_bundled_libraries` should be
`flutter_embedder_bundled_libraries` to match the plugin name.
Flutter's build system expects `${plugin_name}_bundled_libraries`,
so the typo prevented the native DLL from being bundled into
Windows builds.
Fixes ldwformat#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a typo in
windows/CMakeLists.txtthat prevents the native DLL from being bundled on Windows builds.Problem
The variable name
flutter_embedding_bundled_librariesdoes not match the expected convention${plugin_name}_bundled_libraries. Since the plugin name isflutter_embedder, Flutter's build system looks forflutter_embedder_bundled_librariesand finds nothing — resulting in missing DLLs at runtime.Change
Impact
Without this fix, Windows builds crash because the ONNX Runtime DLL is not included in the output directory.
Fixes #1