Skip to content

[Merged by Bors] - chore(NumberField): create directory Cyclotomic and move relevant files there#30536

Closed
xroblot wants to merge 2 commits intoleanprover-community:masterfrom
xroblot:numberfield_cyclo
Closed

[Merged by Bors] - chore(NumberField): create directory Cyclotomic and move relevant files there#30536
xroblot wants to merge 2 commits intoleanprover-community:masterfrom
xroblot:numberfield_cyclo

Conversation

@xroblot
Copy link
Collaborator

@xroblot xroblot commented Oct 14, 2025

Create the directory NumberTheory/NumberField/Cyclotomic and move there the files concerning cyclotomic fields over .

Deprecated modules files are added in #30583


@xroblot xroblot added the WIP Work in progress label Oct 14, 2025
@github-actions
Copy link

github-actions bot commented Oct 14, 2025

PR summary c48ea032ed

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.Cyclotomic.PID -3028
Mathlib.NumberTheory.Cyclotomic.Three -3010
Mathlib.NumberTheory.Cyclotomic.Embeddings -2859
Mathlib.NumberTheory.Cyclotomic.Rat -2520
Mathlib.NumberTheory.NumberField.Cyclotomic.Basic 2520
Mathlib.NumberTheory.NumberField.Cyclotomic.Embeddings 2859
Mathlib.NumberTheory.NumberField.Cyclotomic.Three 3010
Mathlib.NumberTheory.NumberField.Cyclotomic.PID 3028

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

note: file Mathlib/NumberTheory/Cyclotomic/Embeddings.lean` was renamed to `Mathlib/NumberTheory/NumberField/Cyclotomic/Embeddings.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/NumberTheory/Cyclotomic/Three.lean` was renamed to `Mathlib/NumberTheory/NumberField/Cyclotomic/Three.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/NumberTheory/Cyclotomic/PID.lean` was renamed to `Mathlib/NumberTheory/NumberField/Cyclotomic/PID.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/NumberTheory/Cyclotomic/Rat.lean` was renamed to `Mathlib/NumberTheory/NumberField/Cyclotomic/Basic.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

@github-actions github-actions bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label Oct 14, 2025
@xroblot xroblot removed the WIP Work in progress label Oct 15, 2025
@xroblot xroblot added the t-number-theory Number theory (also use t-algebra or t-analysis to specialize) label Oct 15, 2025
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label Oct 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 15, 2025
…iles there (#30536)

Create the directory `NumberTheory/NumberField/Cyclotomic` and move there the files concerning cyclotomic fields over `ℚ`.

Deprecated modules files are added in #30583
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(NumberField): create directory Cyclotomic and move relevant files there [Merged by Bors] - chore(NumberField): create directory Cyclotomic and move relevant files there Oct 15, 2025
@mathlib-bors mathlib-bors bot closed this Oct 15, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 15, 2025
Create the deprecated module files for the files moved in #30536
Jlh18 pushed a commit to Jlh18/mathlib4 that referenced this pull request Oct 24, 2025
…iles there (leanprover-community#30536)

Create the directory `NumberTheory/NumberField/Cyclotomic` and move there the files concerning cyclotomic fields over `ℚ`.

Deprecated modules files are added in leanprover-community#30583
Jlh18 pushed a commit to Jlh18/mathlib4 that referenced this pull request Oct 24, 2025
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
…iles there (leanprover-community#30536)

Create the directory `NumberTheory/NumberField/Cyclotomic` and move there the files concerning cyclotomic fields over `ℚ`.

Deprecated modules files are added in leanprover-community#30583
BeibeiX0 pushed a commit to BeibeiX0/mathlib4 that referenced this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

file-removed A Lean module was (re)moved without a `deprecated_module` annotation ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants