Skip to content

[Merged by Bors] - feat(FieldTheory/IntermediateField/Basic): Add missing coe_div and attributes#36123

Closed
justus-springer wants to merge 1 commit intoleanprover-community:masterfrom
justus-springer:justus/IntermediateField_coe_stuff
Closed

[Merged by Bors] - feat(FieldTheory/IntermediateField/Basic): Add missing coe_div and attributes#36123
justus-springer wants to merge 1 commit intoleanprover-community:masterfrom
justus-springer:justus/IntermediateField_coe_stuff

Conversation

@justus-springer
Copy link
Collaborator

@justus-springer justus-springer commented Mar 4, 2026

Adding simp and norm_cast attributes, since the Subfield versions has them.


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

PR summary 8d466ddc61

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ coe_div

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Contributor

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@robin-carlier robin-carlier added the easy < 20s of review time. See the lifecycle page for guidelines. label Mar 4, 2026
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 4, 2026
@riccardobrasca
Copy link
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 4, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 4, 2026
…attributes (#36123)

Adding simp and norm_cast attributes, since the `Subfield` versions has them.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 4, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(FieldTheory/IntermediateField/Basic): Add missing coe_div and attributes [Merged by Bors] - feat(FieldTheory/IntermediateField/Basic): Add missing coe_div and attributes Mar 4, 2026
@mathlib-bors mathlib-bors bot closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants