Skip to content

[Merged by Bors] - feat: port Archive.Wiedijk100Theorems.BallotProblem#5204

Closed
int-y1 wants to merge 9 commits intomasterfrom
port/Archive.Wiedijk100Theorems.BallotProblem
Closed

[Merged by Bors] - feat: port Archive.Wiedijk100Theorems.BallotProblem#5204
int-y1 wants to merge 9 commits intomasterfrom
port/Archive.Wiedijk100Theorems.BallotProblem

Conversation

@int-y1
Copy link
Contributor

@int-y1 int-y1 commented Jun 18, 2023


todo:

  • counted_succ_succ ran into errors with List

Open in Gitpod

int-y1 added 4 commits June 17, 2023 17:57
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Archive.lean
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels Jun 18, 2023
@kim-em kim-em added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 19, 2023
@mo271
Copy link
Collaborator

mo271 commented Jun 21, 2023

I did a quick fix for the list stuff in counted_succ_succ, now not using any deprecated theorems, but it is slightly verbose, so could need some golf.

@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jun 21, 2023
@int-y1 int-y1 force-pushed the port/Archive.Wiedijk100Theorems.BallotProblem branch from c20573d to fced86d Compare June 21, 2023 10:24
@int-y1 int-y1 added awaiting-review and removed help-wanted The author needs attention to resolve issues labels Jun 21, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 21, 2023
bors bot pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Jun 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Archive.Wiedijk100Theorems.BallotProblem [Merged by Bors] - feat: port Archive.Wiedijk100Theorems.BallotProblem Jun 21, 2023
@bors bors bot closed this Jun 21, 2023
@bors bors bot deleted the port/Archive.Wiedijk100Theorems.BallotProblem branch June 21, 2023 11:07
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
kim-em pushed a commit that referenced this pull request Jun 23, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
kim-em pushed a commit that referenced this pull request Jun 23, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
kim-em pushed a commit that referenced this pull request Jun 25, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants