Draft
Conversation
07d8f5f to
6621bb5
Compare
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 83.98% 83.68% -0.31%
==========================================
Files 70 71 +1
Lines 6383 6443 +60
==========================================
+ Hits 5361 5392 +31
- Misses 1022 1051 +29
|
6621bb5 to
fee6195
Compare
| weights: torch.Tensor, | ||
| tau: float = 1.0, | ||
| n_iters: int = 20, | ||
| stop_delta: Optional[float] = None, |
Member
There was a problem hiding this comment.
preference: let's default to some reasonable delta and a very large n steps
Member
|
Random thoughts:
|
borzunov
commented
Nov 21, 2021
borzunov
commented
Nov 21, 2021
borzunov
commented
Apr 10, 2022
| prev_diff = result | ||
|
|
||
| # We only need to update `diff` (not `result`) between iterations | ||
| diff.addmm_(-coeffs.repeat(n_peers, 1), diff) |
Member
Author
There was a problem hiding this comment.
Suggested change
| diff.addmm_(-coeffs.repeat(n_peers, 1), diff) | |
| diff -= coeffs @ diff |
It seems like addmm_() doesn't work correctly if the destination is equal to one of the operands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MeanReducer,CenteredClipReducer(btw, why not*Aggregator?)Factoryto smth else,make_reducer: Callable[...]