Rework example task layout by allnes · Pull Request #786 · learning-process/parallel_programming_course

allnes · 2026-06-02T23:56:29Z

What changed

Reworked the old example directories into one tasks/example tree with threads and processes/t1, processes/t2, processes/t3 sections.
Removed the old physical example directories: tasks/example_threads, tasks/example_processes, tasks/example_processes_2, and tasks/example_processes_3.
Added unified example metadata and shared resources at tasks/example/settings.json, tasks/example/info.json, tasks/example/common, and tasks/example/data.
Updated CMake support for the example meta-layout and -DPPC_TASKS=example.
Updated example functional and performance tests for the new threads and processes/t1..t3 layout.
Updated nested settings handling so each example implementation can be enabled or disabled independently.
Updated the performance table parser and scoreboard support for the new example layout.

codecov · 2026-06-03T00:30:34Z

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.73%. Comparing base (3b1f08c) to head (674221f).

Files with missing lines	Patch %	Lines
modules/task/include/task.hpp	73.91%	2 Missing and 4 partials ⚠️

❌ Your patch check has failed because the patch coverage (73.91%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #786      +/-   ##
==========================================
+ Coverage   27.07%   28.73%   +1.66%     
==========================================
  Files          15       15              
  Lines         495      515      +20     
  Branches      185      199      +14     
==========================================
+ Hits          134      148      +14     
- Misses        351      353       +2     
- Partials       10       14       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aobolensk · 2026-06-03T14:00:16Z

+
+Child reports:
+
+- `seq/report.md`
+- `mpi/report.md`


Suggested change

Child reports:

- `seq/report.md`

- `mpi/report.md`

@aobolensk it is part of report - only teplate next pr I'll add description

aobolensk · 2026-06-03T14:00:37Z

+
+Child reports:
+
+- `seq/report.md`
+- `omp/report.md`
+- `tbb/report.md`
+- `stl/report.md`
+- `all/report.md`


Suggested change

Child reports:

- `seq/report.md`

- `omp/report.md`

- `tbb/report.md`

- `stl/report.md`

- `all/report.md`

@aobolensk it is part of report - only teplate next pr I'll add description

aobolensk · 2026-06-03T14:00:54Z

+
+Child reports:
+
+- `t1/report.md`
+- `t2/report.md`
+- `t3/report.md`


Suggested change

Child reports:

- `t1/report.md`

- `t2/report.md`

- `t3/report.md`

@aobolensk it is part of report - only teplate next pr I'll add description

aobolensk · 2026-06-03T14:01:05Z

+
+Child reports:
+
+- `seq/report.md`
+- `mpi/report.md`


Suggested change

Child reports:

- `seq/report.md`

- `mpi/report.md`

@aobolensk it is part of report - only teplate next pr I'll add description

aobolensk · 2026-06-03T14:02:34Z

  .. code-block:: json

-     { "student": { "full_name": "Фамилия Имя Отчество", "group_number": "Группа", "task_number": "1" } }
+     { "student": { "last_name": "Фамилия", "first_name": "Имя", "middle_name": "Отчество", "group_number": "Группа" } }


Are you sure you want to change it also right here right now?

Fixed. The metadata format is back to full_name + group_number

aobolensk · 2026-06-03T14:04:15Z

+  for (size_t start = 0; start < settings_task_path.size();) {
+    const size_t separator = settings_task_path.find('.', start);
+    const size_t key_size = separator == std::string_view::npos ? settings_task_path.size() - start : separator - start;
+    settings_node = &settings_node->at(std::string(settings_task_path.substr(start, key_size)));


Please, make a proper error hanling here instead of using .at()

Fixed. Replaced direct .at() access with explicit key validation and contextual runtime errors, and added a unit test for missing nested settings paths.

aobolensk · 2026-06-03T14:05:04Z

Please, make sure that all .po files are actually update

Updated the translation catalogs with sphinx-intl after regenerating gettext catalogs. docs_gettext, docs_update, and docs_html pass locally.

Co-authored-by: Arseniy Obolenskiy <gooddoog@student.su>

aobolensk · 2026-06-03T15:11:05Z

+" updates periodically.*"
+msgstr ""
+
+#~ msgid ""


Please, remove garbage

aobolensk · 2026-06-03T15:11:26Z

+[*.{bat,cmd}]
+end_of_line = crlf


Is it needed?

Yes. The repository has a tracked Windows batch script with CRLF line endings (scripts/generate_perf_results.bat), while the global EditorConfig rule sets end_of_line = lf for all files. This override resolves that conflict for .bat/.cmd files and keeps Windows scripts in their native line-ending format.

Is it necessary for this patch? I'd even separate docs part at this point as well

allnes · 2026-06-03T15:25:31Z

@aobolensk done

aobolensk · 2026-06-03T15:32:23Z

+    EXPECT_NE(std::string(e.what()).find("tasks.processes.t2"), std::string::npos);
+    throw;
+  },
+               std::runtime_error);


This formatting is strange. Does that really pass clang-format? If not and some clang-format related changes are required, I suggest fixing it separately later

It's part of ci, ci was green. I think it's bug.

@aobolensk fixed

aobolensk · 2026-06-03T15:42:41Z

Please update description of the PR

aobolensk

LGTM

Rework example task layout

c19b22b

github-actions Bot added task:mpi task:omp task:tbb task:seq task:stl infrastructure docs task:all scoreboard modules:util modules:task task report labels Jun 2, 2026

allnes marked this pull request as ready for review June 2, 2026 23:57

allnes requested a review from aobolensk as a code owner June 2, 2026 23:57

Apply pre-commit formatting

a226569

allnes changed the title ~~[codex] Rework example task layout~~ Rework example task layout Jun 3, 2026

This comment was marked as off-topic.

Sign in to view

Fix clang-tidy include warnings

902fafb

aobolensk reviewed Jun 3, 2026

View reviewed changes

allnes and others added 6 commits June 3, 2026 16:10

Update tasks/example/report.md

c5fb33e

Co-authored-by: Arseniy Obolenskiy <gooddoog@student.su>

Update docs/common_information/introduction.rst

c1ec2eb

Co-authored-by: Arseniy Obolenskiy <gooddoog@student.su>

Address example layout review feedback

5879ca9

Use split student fields in docs example

7d7502c

Use full_name in example metadata

76af06e

Read student full_name directly

7c0d5db

allnes requested a review from aobolensk June 3, 2026 15:06

aobolensk reviewed Jun 3, 2026

View reviewed changes

allnes added 2 commits June 3, 2026 17:18

Clean regenerated translation catalogs

356e6bb

Remove docs changes from example layout PR

5aac6c3

github-actions Bot removed the docs label Jun 3, 2026

allnes requested a review from aobolensk June 3, 2026 15:25

aobolensk reviewed Jun 3, 2026

View reviewed changes

Clean up nested settings test formatting

674221f

allnes requested a review from aobolensk June 3, 2026 15:37

aobolensk approved these changes Jun 3, 2026

View reviewed changes

allnes enabled auto-merge June 3, 2026 16:01

allnes added this pull request to the merge queue Jun 3, 2026

Merged via the queue into learning-process:master with commit 8ab7b17 Jun 3, 2026
39 of 40 checks passed

allnes deleted the an/change-layout branch June 3, 2026 17:24

		[*.{bat,cmd}]
		end_of_line = crlf

Conversation

allnes commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Uh oh!

This comment was marked as off-topic.

Uh oh!

codecov Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

allnes commented Jun 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aobolensk commented Jun 3, 2026

Uh oh!

aobolensk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

allnes commented Jun 2, 2026 •

edited

Loading

codecov Bot commented Jun 3, 2026 •

edited

Loading