Restore example backend test filtering#787
Merged
Merged
Conversation
allnes
reviewed
Jun 3, 2026
| } | ||
|
|
||
| TEST_F(NesterovARunFuncTestsThreads, MatmulFromPicTbbEnabled) { | ||
| RunTestCasesWithTag(kTestTasksList, "_tbb_"); |
Member
There was a problem hiding this comment.
could we make RunTestCasesWithTag(kTestTasksList, "tbb"); for all cases and what happen if I forget it? I wait for fail.
allnes
reviewed
Jun 3, 2026
| ExecuteTest(test_param); | ||
| } | ||
|
|
||
| void RunTestCasesWithTag(const auto &test_tasks_list, const std::string &task_tag) { |
Member
There was a problem hiding this comment.
is it common function? can we move to util?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #787 +/- ##
===========================================
+ Coverage 28.73% 92.42% +63.68%
===========================================
Files 15 15
Lines 515 515
Branches 199 199
===========================================
+ Hits 148 476 +328
+ Misses 353 4 -349
- Partials 14 35 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
allnes
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should also restore test coverage level