Invalid url format for aphrodite fork in the package.json file

[marsian83]

Observed behavior

When setting up studio for local development
After following through the steps mentioned here
Once you reach the Install frontend dependencies part
after installing node and yarn with volta by executing the commands :

volta install node@16
volta install yarn

when you try to install the dependencies by using

yarn install

An error appears as shown:

➤ YN0001: │ Error: aphrodite@https://github.com/learningequality/aphrodite/ isn't supported by any available resolver
    at vd.getResolverByDescriptor (/home/marsian/.volta/tools/image/yarn/4.0.0-rc.36/bin/yarn.js:135:1698)
    at vd.bindDescriptor (/home/marsian/.volta/tools/image/yarn/4.0.0-rc.36/bin/yarn.js:135:1083)
    at St.preparePackage (/home/marsian/.volta/tools/image/yarn/4.0.0-rc.36/bin/yarn.js:204:5497)
    at async g (/home/marsian/.volta/tools/image/yarn/4.0.0-rc.36/bin/yarn.js:204:6789)

which occurs due to the fact that in the package.json file in the devDependencies at line 100

"aphrodite": "https://github.com/learningequality/aphrodite/"

is uninstallable as it has no suffix.
in this case it should have a .git suffix to affirm that it's a git repository

Expected behavior

yarn install

running the above command installs all dependencies without any errors

User-facing consequences

Any new developer may not be able to set up a development environment

Errors and logs

➤ YN0000: ┌ Resolution step
➤ YN0014: │ aphrodite@https://github.com/learningequality/aphrodite/: Only some patterns can be imported from legacy lockfiles (not "https://github.com/learningequality/aphrodite/#fdc8d7be8912a5cf17f74ff10f124013c52c3e32")
➤ YN0001: │ Error: aphrodite@https://github.com/learningequality/aphrodite/ isn't supported by any available resolver
    at vd.getResolverByDescriptor (/home/marsian/.volta/tools/image/yarn/4.0.0-rc.36/bin/yarn.js:135:1698)
    at vd.bindDescriptor (/home/marsian/.volta/tools/image/yarn/4.0.0-rc.36/bin/yarn.js:135:1083)
    at St.preparePackage (/home/marsian/.volta/tools/image/yarn/4.0.0-rc.36/bin/yarn.js:204:5497)
    at async g (/home/marsian/.volta/tools/image/yarn/4.0.0-rc.36/bin/yarn.js:204:6789)
➤ YN0000: └ Completed in 0s 279ms
➤ YN0000: Failed with errors in 0s 288ms

Additional information

There are also instances of this in the yarn.lock file which can also use a suffix

Steps to reproduce the issue

1. attempt to setup studio for local development as given here
2. yarn install
3. see error

Usage Details

• OS: Ubuntu WSL on windows 11

[marsian83]

I have filed a PR #3923 which adds the .git suffix to the aphrodite fork in the package.json file
I hope this was something that needed fixing and not just me messing something up during my installation process
Please do let me know if I should also do the same with the urls in yarn.lock
especially in line 2509 of yarn.lock

  resolved "https://github.com/learningequality/aphrodite/#fdc8d7be8912a5cf17f74ff10f124013c52c3e32"

I reckon it must be

  resolved "https://github.com/learningequality/aphrodite.git#fdc8d7be8912a5cf17f74ff10f124013c52c3e32"

so that it targets that (fdc8d7be8912a5cf17f74ff10f124013c52c3e32) specific commit in the aphrodite fork on git