Skip to content

Review fixes for #2280#2301

Closed
MisRob wants to merge 20 commits intolearningequality:developfrom
MisRob:kds-fixes
Closed

Review fixes for #2280#2301
MisRob wants to merge 20 commits intolearningequality:developfrom
MisRob:kds-fixes

Conversation

@MisRob
Copy link
Copy Markdown
Member

@MisRob MisRob commented Sep 25, 2020

Description

In this PR, I've been addressing some issues that would be good to have ready in develop before the bug hunt.

  1. Merge develop
  2. Fix unwanted background green color on assessment answers
  3. Fix changing size of a tree list item on hover
  4. Center a topic badge in the clipboard (@nucleogenesis I know that you mentioned that you fixed it in the original PR so I am thinking that maybe merging develop broke it again)

nucleogenesis and others added 20 commits September 24, 2020 13:57
top margin pushed the arrows to be flush with the bottom
rather than centered vertically alongside the tab buttons
This commit is too big but it is not worth breaking
down into smaller commits because much of it is
interconnected and I should have done so in progress
the add circle outline icon is not in the design system at this time
so we will need to address this later if desired.
KDS theme tokens contain `correct`
field that is set to green (#43A047).
Answers editor used this class to mark
correct answers which introduced
green background to them which should
not be there.
to prevent height glitches on hover
now when we use vertical options
button instead of the horizontal one.
@MisRob
Copy link
Copy Markdown
Member Author

MisRob commented Sep 25, 2020

Closing, I wanted to target another repository.

@MisRob MisRob closed this Sep 25, 2020
@MisRob MisRob deleted the kds-fixes branch November 3, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants