Skip to content

Edit modal - add completion/duration dropdowns and mastery fields tests #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtibbles merged 14 commits into from
Jul 28, 2022
Merged

Edit modal - add completion/duration dropdowns and mastery fields tests #3464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3e1e52b
Add activity duration component tests and refactor some methods
sairina Jul 19, 2022
7b489d1
Update MasteryGoal and test
sairina Jul 20, 2022
0a9c003
Fix component name in test and linting
sairina Jul 20, 2022
d8095bf
Updates to mofn fields tests
sairina Jul 20, 2022
415c948
Add completion dropdown initial states tests and adjustments to compo…
sairina Jul 21, 2022
5c583f5
Add duration dropdown default states tests and update code
sairina Jul 21, 2022
88307c6
Add tests for emitting
sairina Jul 21, 2022
dc7f15a
Add tests for document changing state in all content viewed
sairina Jul 21, 2022
aa56d59
Add tests for document changing state in complete duration
sairina Jul 21, 2022
6bd38d1
Add tests for exercises and duration dropdown states
sairina Jul 22, 2022
7ca87d1
Add tests and fix code for HTML5 and H5P
sairina Jul 22, 2022
60a8362
Add tests for minutes input and move logic for handling rounding into…
sairina Jul 22, 2022
5647998
Fix model for default states tests
sairina Jul 22, 2022
78da01f
Tweaks to tests.
rtibbles Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions contentcuration/contentcuration/frontend/channelEdit/components/edit/ActivityDuration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@
},
computed: {
showRequiredLabel() {
if (this.audioVideoUpload) {
return false;
}
return (
this.selectedDuration !== DurationDropdownMap.EXACT_TIME &&
this.selectedCompletion === CompletionDropdownMap.completeDuration
Expand All @@ -121,7 +124,7 @@
return this.convertToMinutes(this.value);
},
set(value) {
this.handleValidateMinutes(value);
this.handleUpdatedInput(value);
},
},
maxRange() {
Expand Down Expand Up @@ -152,20 +155,17 @@
},
},
created() {
this.handleValidateMinutes = debounce(this.validateMinutes, 500);
this.handleUpdatedInput = debounce(this.handleInput, 500);
},
methods: {
convertToMinutes(seconds) {
return Math.floor(seconds / 60);
},
validateMinutes(value) {
if (this.selectedDuration === DurationDropdownMap.EXACT_TIME) {
this.$emit('input', value * 60);
} else {
if (value >= this.minRange && value <= this.maxRange) {
this.$emit('input', value * 60);
}
}
convertToSeconds(minutes) {
return minutes * 60;
},
handleInput(value) {
this.$emit('input', this.convertToSeconds(value));
},
},
$trs: {
Expand Down
Loading