Skip to content

Add a check for new entries in the changes table to ensure swift syncing of non-Dexie observable changes. #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjester merged 2 commits into from
Aug 31, 2022
Merged

Add a check for new entries in the changes table to ensure swift syncing of non-Dexie observable changes. #3591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6eba7b
Add a check for new entries in the changes table to ensure swift sync…
rtibbles Aug 30, 2022
56d8784
Add additional check to only try to sync unsynced changes.
rtibbles Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion contentcuration/contentcuration/frontend/shared/data/serverSync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,17 @@ if (process.env.NODE_ENV !== 'production' && typeof window !== 'undefined') {
async function handleChanges(changes) {
changes.map(applyResourceListener);
const syncableChanges = changes.filter(isSyncableChange);
// Here we are handling changes triggered by Dexie Observable
// this is listening to all of our IndexedDB tables, both for resources
// and for our special Changes table.
// Here we look for any newly created changes in the changes table, which may require
// a sync to send them to the backend - this is particularly important for
// MOVE, COPY, PUBLISH, and SYNC changes where we may be executing them inside an IGNORED_SOURCE
// because they also make UPDATE and CREATE changes that we wish to make in the client only.
// Only do this for changes that are not marked as synced.
const newChangeTableEntries = changes.some(
c => c.table === CHANGES_TABLE && c.type === CHANGE_TYPES.CREATED && !c.obj.synced
);

if (syncableChanges.length) {
// Flatten any changes before we store them in the changes table
Expand All @@ -323,7 +334,7 @@ async function handleChanges(changes) {

// If we detect changes were written to the changes table
// then we'll trigger sync
if (syncableChanges.length) {
if (syncableChanges.length || newChangeTableEntries) {
debouncedSyncChanges();
}
}
Expand Down