[Remove Vuetify from Studio] Collection channels loader in Channels - New collection#5388
[Remove Vuetify from Studio] Collection channels loader in Channels - New collection#5388nishatalam24 wants to merge 9 commits intolearningequality:unstablefrom
Conversation
This reverts commit 0701d5b.
…earningequality#5244)" This reverts commit f9bee66.
…earningequality#5244)" This reverts commit 96f21da.
|
Thank you @nishatalam24, we will assign a reviewer soon. |
MisRob
changed the title
| .loader-text { | ||
| margin-top: 16px; | ||
| font-size: 1.2em; | ||
| color: #555555; |
There was a problem hiding this comment.
Lets use the the KDS colors here. There are quite a number of examples on how this can be done eg $themeTokens, $themePalette, etc. Heres a example
There was a problem hiding this comment.
Because of https://github.com/learningequality/studio/pull/5388/files#r2388418039, this css class should be removed as well
| <KCircularLoader :size="70" /> | ||
| <div class="loader-text"> | ||
| <slot ></slot> | ||
| </div> |
There was a problem hiding this comment.
This is not required, so should be removed.
| align-items: center; | ||
| justify-content: center; | ||
| min-height: 180px; | ||
| } |
There was a problem hiding this comment.
Simplify this css class in light of https://github.com/learningequality/studio/pull/5388/files#r2388418039
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: center; | ||
| min-height: 180px; |
There was a problem hiding this comment.
I think the loader size should be set using the size prop of the KCircularLoader so setting min-hight may not be useful in this case.
akolson
left a comment
akolson
left a comment
There was a problem hiding this comment.
Hi @nishatalam24! Great work so far! We have the building blocks in place, so just a little clean up and we should be good to go! Thanks!
|
Also a reminder to take a look at the linting errors reported here. I suspect that you haven't install the pre-commit hook. To install the hook, run |
|
Hi @nishatalam24! This is just follow up about the progress on this. Hope everything is okay? |
|
As per #5244 (comment), I will close this PR. Samson, in the note I asked a new contributor to follow your review, so that work is not lost :) Thank you. |
3 participants
Summary
This pull request addresses and closes issue #5244 by creating a new
StudioLargeLoadercomponent and replacing the old loaders in two locations.Changes
StudioLargeLoader.vue, was created to be a reusable, Vuetify-free loader that uses the Kolibri Design System's<KCircularLoader>.ChannelSetModaland theStorageoverview page.References
This pull request closes #5244.
Reviewer Guidance
All user interactions have been manually tested, and the loaders now function as expected with a modern, KDS-compliant design.