Skip to content

Fix channel pdf summary output#5690

Merged
MisRob merged 1 commit intolearningequality:unstablefrom
MisRob:fix-printing
Feb 20, 2026
Merged

Fix channel pdf summary output#5690
MisRob merged 1 commit intolearningequality:unstablefrom
MisRob:fix-printing

Conversation

@MisRob
Copy link
Copy Markdown
Member

@MisRob MisRob commented Feb 4, 2026

Summary

Follow-up to #5540 where we removed Vuetify from channel details page. That caused some errors as well as visual problems in the generated channel summary PDF, particularly for channels with no thumbnail images available.

This PR optimizes the new page implementation to produce the expected PDF output.

Screenshot of one of the channels PDF from my localhost:

Reviewer guidance

  • Code: Since this just optimizes very recently added logic, I think that there's no need to compare with the previous version. Perhaps just have a look at it as a whole.
  • Testing: I think it would be best to preview pdfs on production-like data for channels and resources with and without thumbnails on the unstable server after we merge.

Copy link
Copy Markdown
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it in my local and looked over a downloaded pdf of the channel details, everything looks fine to me, no concerns.

@MisRob
Copy link
Copy Markdown
Member Author

MisRob commented Feb 20, 2026

Okay, thanks for trying it too @LianaHarris360

@MisRob MisRob merged commit a0f3e79 into learningequality:unstable Feb 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants