[OU-FIX] loyalty: rewrite removed _get_mail_partner in stored templates#78
Open
dnplkndll wants to merge 1 commit into
Open
[OU-FIX] loyalty: rewrite removed _get_mail_partner in stored templates#78dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
dnplkndll
force-pushed
the
19.0-mig-loyalty-pre-migration
branch
4 times, most recently
from
May 30, 2026 03:16
46ce1c3 to
3ff9c2e
Compare
dnplkndll
force-pushed
the
19.0-mig-loyalty-pre-migration
branch
2 times, most recently
from
June 5, 2026 19:53
443d4fb to
49d0b1e
Compare
dnplkndll
force-pushed
the
19.0-mig-loyalty-pre-migration
branch
4 times, most recently
from
June 19, 2026 11:59
a6d3851 to
e1c2372
Compare
19.0 removed loyalty.card's _get_mail_partner() helper. Customized mail.templates still referencing it abort the noupdate data-load render (and _get_mail_author would substitute the wrong partner). Rewrite the stored references to their 18.0 equivalent object.partner_id, on top of upstream's fix_template_lang.
dnplkndll
force-pushed
the
19.0-mig-loyalty-pre-migration
branch
from
July 16, 2026 20:42
e1c2372 to
b8912d9
Compare
dnplkndll
changed the title
_get_mail_partner in stored mail.template.lang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slimmed to the genuine delta on top of upstream's now-landed
loyalty/19.0.1.0migration (reconciliation vs OCA/19.0).19.0 removed
loyalty.card's_get_mail_partner()helper. Customizedmail.templates still referencing it abort the noupdate data-load render, and_get_mail_authorwould substitute the wrong partner. This rewrites the stored references (lang/partner_to/email_to/body_html, jsonb-aware) to their 18.0 equivalentobject.partner_id.Dropped from the earlier version (covered upstream): the
langreset — upstream'sfix_template_lang(pre) +load_data(post) already handle it.