Skip to content

Cmake improvements and simple ci#9

Merged
leejet merged 4 commits into
leejet:masterfrom
Green-Sky:cmake
Aug 17, 2023
Merged

Cmake improvements and simple ci#9
leejet merged 4 commits into
leejet:masterfrom
Green-Sky:cmake

Conversation

@Green-Sky

Copy link
Copy Markdown
Contributor

I took the liberties to move some source files around, to match other ggml projects (somewhat). Please tell me if that is ok :)

I suggest renaming the stable-diffusion.h to .hpp, to signal it being a c++ header.

added simple ci that build on all 3 major platforms. nothing sophisticated, and no testing, since no test code is written yet.

@Green-Sky

Copy link
Copy Markdown
Contributor Author

@leejet

leejet commented Aug 17, 2023

Copy link
Copy Markdown
Owner

Great!

@leejet

leejet commented Aug 17, 2023

Copy link
Copy Markdown
Owner

I suggest renaming the stable-diffusion.h to .hpp, to signal it being a c++ header.

For header files that do not contain implementations, I prefer using .h instead of .hpp.

@leejet
leejet merged commit 844351c into leejet:master Aug 17, 2023
@Green-Sky
Green-Sky deleted the cmake branch November 23, 2024 12:47
kenvandine referenced this pull request in lemonade-sdk/stable-diffusion.cpp Jun 1, 2026
ci: match lemonade-sdk/llama.cpp CUDA library bundling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants