Skip to content

add ripple effect when tapping on the IconSlideAction widget #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
letsar merged 1 commit into from
Oct 6, 2019
+10 −3
Merged

add ripple effect when tapping on the IconSlideAction widget #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/src/widgets/slide_action.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ abstract class ClosableSlideAction extends StatelessWidget {
/// The [closeOnTap] argument must not be null.
const ClosableSlideAction({
Key key,
this.color,
this.onTap,
this.closeOnTap = _kCloseOnTap,
}) : assert(closeOnTap != null),
super(key: key);

final Color color;
/// A tap has occurred.
final VoidCallback onTap;

Expand All @@ -34,8 +36,13 @@ abstract class ClosableSlideAction extends StatelessWidget {

Widget build(BuildContext context) {
return GestureDetector(
onTap: !closeOnTap ? onTap : () => _handleCloseAfterTap(context),
child: buildAction(context),
child: Material(
color: color,
child: InkWell(
onTap: !closeOnTap ? onTap : () => _handleCloseAfterTap(context),
child: buildAction(context),
),
),
);
}

Expand Down Expand Up @@ -116,6 +123,7 @@ class IconSlideAction extends ClosableSlideAction {
'Either set icon or iconWidget.'),
super(
key: key,
color: color,
onTap: onTap,
closeOnTap: closeOnTap,
);
Expand Down Expand Up @@ -181,7 +189,6 @@ class IconSlideAction extends ClosableSlideAction {
}

return Container(
color: color,
child: Center(
child: Column(
mainAxisSize: MainAxisSize.min,
Expand Down