Revert "sa: truncate all timestamps to seconds (#7519)"#7559
Merged
Conversation
This reverts commit 2b5b623.
pgporada
reviewed
Jun 24, 2024
aarongable
previously approved these changes
Jun 24, 2024
aarongable
left a comment
aarongable
left a comment
Contributor
There was a problem hiding this comment.
LGTM modulo keeping the documentation improvements.
beautifulentropy
previously requested changes
Jun 25, 2024
beautifulentropy
left a comment
beautifulentropy
left a comment
Member
There was a problem hiding this comment.
As Aaron mentioned in his review, please leave the "Rounding time in DB" documentation intact.
aarongable
approved these changes
Jun 25, 2024
pgporada
approved these changes
Jun 26, 2024
jsha
dismissed
beautifulentropy’s stale review
Restored the "Rounding time in DB" documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2b5b623.
Following up on #7556, after we made a more systematic change to use borp's TypeConverter, we no longer need to manually truncate timestamps.