Update go-sql-driver/mysql from v1.5.0 to v1.7.1#8138
Merged
Conversation
Contributor
To be precise, this truncates timestamps on write, and also on querying. Last time we tried this upgrade, it was to 1.7.1: #7006. I have a bit of a preference to try upgrading to 1.7.1 again, to minimize variables. That way if something goes wrong we are less likely to second guess ourselves, like "was there something new in 1.8 or 1.9 that did it?" Then hopefully the subsequent upgrade to 1.9.2 will be a nothingburger. |
beautifulentropy
previously approved these changes
Apr 23, 2025
aarongable
changed the title
Contributor
Author
|
@jsha I've downgraded this to v1.7.1, PTAL |
jsha
approved these changes
Apr 24, 2025
beautifulentropy
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version v1.5.0 was released in January 2020, over five years ago. We have attempted to update this package several times since then -- first to v1.6.0, later to v1.7.1 -- but have reverted the change due to nigh-inexplicable performance regressions each time. Since our last attempt, we believe we have addressed the underlying issue by truncating timestamps when we talk to the database (see #7556) so that our indices don't try to track nanosecond precision.
We are now ready to reattempt updating this package to v1.7.1 again. If that goes well, we will further update it to the newest version.
Fixes #5437
Part of #7872