Refactor: Call the shared release workflow - #11
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the repository’s tag-push release automation to delegate validation and draft-release promotion to the shared lfreleng-actions/generic-workflows reusable release workflow (pinned to v0.0.3), reducing duplicated workflow logic and adopting the organization’s default release-gating policy.
Changes:
- Replaced the former “fat” tag-push workflow graph with a thin reusable-workflow caller pinned to
b80a5a8…(v0.0.3). - Renamed the workflow file from
tag-push.yamltorelease.yamlwhile preserving the existing concurrency serialization pattern.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/tag-push.yaml |
Removed the duplicated validate-and-promote job graph previously run on tag pushes. |
.github/workflows/release.yaml |
Added a thin workflow that triggers on tag push and calls the shared reusable release workflow (pinned to v0.0.3), retaining the repo-specific concurrency group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The tag-push.yaml here duplicated a validate-then-promote job graph that almost a hundred repositories each carried their own copy of. Replace it with a caller that delegates to the release reusable in generic-workflows, pinned to v0.0.3. Rename the file to release.yaml. The name describes the outcome rather than the trigger, and sits beside the release-drafter.yaml that creates the draft this workflow publishes. The caller passes no inputs, so it adopts the organisation's default gating policy in full. Where a repository enforced only the versioning scheme, signature and pre-release checks, that adds four gates: enforce_increment, require_branch (default branch), require_recent (three minutes) and require_latest. Tags that are stale, raised off the default branch, or not at its tip now fail instead of producing a faulty immutable release. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
fadef8c to
4d54588
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/release.yaml:45
- PR description says the reusable workflow should be pinned to generic-workflows v0.0.3 (commit b80a5a8…), but this workflow currently calls commit 007258a… (annotated as v0.0.4). Please align the pin with the PR description (either update the ref here, or update the PR description if v0.0.4 is intended).
uses: lfreleng-actions/generic-workflows/.github/workflows/release.yaml@007258a132e4ba5358a20a5c0a902fa04de3a045 # v0.0.4
tykeal
left a comment
There was a problem hiding this comment.
🤖 Dependamerge
Approved this pull request ✅
Why
tag-push.yamlhere duplicated a validate-then-promote job graph that 96repositories each carried their own copy of. This replaces it with a thin
caller delegating to the
release reusable in
generic-workflows,pinned to
v0.0.4
(
007258a132e4ba5358a20a5c0a902fa04de3a045).Renamed to
release.yamlThe name describes the outcome rather than the trigger, and sits beside the
release-drafter.yamlthat creates the draft this workflow publishes.Behaviour changes to be aware of
The caller passes no inputs, so it adopts the reusable's defaults in full —
the release-gating policy and the runner-hardening defaults.
1. Gating. Repositories that enforced only the versioning scheme, signature
and pre-release checks gain four gates:
enforce_incrementrequire_branchrequire_recentrequire_latestTags that are stale, raised off the default branch, or not at its tip now fail
rather than produce a faulty immutable release. This is the intended
organisation-wide default; it had simply not been rolled out everywhere. Eight
repositories already carried all eight gates — for those, nothing tightens.
2. Runner hardening. 14 repositories still ran harden-runner in
auditmode and move to
block. Every one of those 14 also lacks theharden-runner-block-actionallow-list loader, while all 82 onblockhaveit — they are stragglers on an older template, not deliberate opt-outs. After
this conversion all 96 run an identical workflow, so the egress profile is
uniform and already proven by the 82 running these exact steps under
block.3. Concurrency. Six repositories used a global group
(
${{ github.workflow }}), serialising all releases; they move to theestate-standard per-tag group (
${{ github.workflow }}-${{ github.ref }}).Distinct tags are independent work, and the reusable serialises itself per-tag
as well.
mark_latestdefaults totrue, matching thelatest: truethe old promotestep passed.
Tag deletions
Deleting a tag also fires this
pushevent. The reusable already guards itsown jobs with
if: ${{ !github.event.deleted }}, but the caller carries theguard too so that — exactly as before — no run starts at all.
Validation
The reusable and this caller pattern were exercised end-to-end in
test-release-process,the repository built to test the organisation's release tooling: a signed tag
push validated against the full gate set and promoted its draft release. This
generated caller passes
actionlintandyamllintagainst this repository'sown configuration.
Review note
The caller keeps its own
concurrencyblock. That is safe: the reusableserialises under
generic-workflows-release-${{ github.ref }}, a literalprefix that cannot collide with the caller's own group.
timeout-minutesis deliberately absent — GitHub does not permit it on a jobthat calls a reusable workflow (
actionlintrejects it). The reusable sets itsown timeouts of 2, 5 and 5 minutes on its three jobs.