Skip to content

Fix: Env-mediate expressions in run blocks #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tykeal merged 1 commit into from
Jul 28, 2026
Merged

Fix: Env-mediate expressions in run blocks #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .github/workflows/testing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,20 +106,23 @@ jobs:

- name: "Validate action output: ${{ github.repository }}"
shell: bash
env:
PROJECT_VERSION: ${{ steps.test.outputs.python_project_version }}
VERSION_SOURCE: ${{ steps.test.outputs.source }}
DYN_IS_DYNAMIC: ${{ steps.test.outputs.dynamic_version }}
run: |
# Validate Action Output
if [ "${{ steps.test.outputs.python_project_version }}" \
= '0.0.1' ]; then
if [ "$PROJECT_VERSION" = '0.0.1' ]; then
echo "Action returned the expected version ✅"
else
echo 'Unexpected return value for: python_project_version ❌'
echo "Returned: ${{ steps.test.outputs.python_project_version }}"
echo "Returned: $PROJECT_VERSION"
echo 'Expected: 0.0.1'
exit 1
fi
# Source output must be the actual file path now, not the
# version string (regression test for the previous copy-paste bug).
source='${{ steps.test.outputs.source }}'
source="$VERSION_SOURCE"
case "$source" in
*pyproject.toml)
echo "Source output is correct ($source) ✅"
Expand All @@ -131,7 +134,7 @@ jobs:
;;
esac
# Verify the new outputs are present and have expected values.
if [ "${{ steps.test.outputs.dynamic_version }}" != 'false' ]; then
if [ "$DYN_IS_DYNAMIC" != 'false' ]; then
echo 'Expected dynamic_version=false for a static-version project ❌'
exit 1
fi
Expand All @@ -150,10 +153,14 @@ jobs:

- name: "Validate dynamic version output"
shell: bash
env:
DYN_VERSION: ${{ steps.test-dynamic.outputs.python_project_version }}
DYN_IS_DYNAMIC: ${{ steps.test-dynamic.outputs.dynamic_version }}
DYN_PROVIDER: ${{ steps.test-dynamic.outputs.dynamic_provider }}
run: |
version='${{ steps.test-dynamic.outputs.python_project_version }}'
dynamic='${{ steps.test-dynamic.outputs.dynamic_version }}'
provider='${{ steps.test-dynamic.outputs.dynamic_provider }}'
version="$DYN_VERSION"
dynamic="$DYN_IS_DYNAMIC"
provider="$DYN_PROVIDER"
if [ "$version" != 'dynamic' ] || [ "$dynamic" != 'true' ]; then
echo 'Dynamic versioning not detected ❌'
echo "version=$version dynamic_version=$dynamic"
Expand Down
Loading