Conversation
Avoid multiple indirections by storing the Param pointer for the data argument in a temporary variable.
|
LGTM. Thanks! |
Data bound to a callback must be flagged as "internal". The problem is also the callback itself is marked as such because of this issue: https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/430 Avoid the problem by checking the scope: if it is invalid, it is likely real data (and not a callback), hence it can be marked. Fixes lgi-devs#241, lgi-devs#262 and lgi-devs#285.
|
You got a "LGTM" from pavouk, produced a PR with nice, small, self-contained commits, you are touching code that I do not understand. I want you on the team! Merging based on the "LGTM" from someone who definitely knows this stuff and since this seems like you know what you are doing. Thanks a lot! |
Thank you: lately I'm using LGI sparingly but I would be happy to help where I can. Not sure what to do though...
"seems" is the keyword here 😄 I did not grasp that much: I just got the intent of the |
3 participants
This touches a quite delicate part of LGI, so it probably requires much more eyeballs than only mine.