Update publishing to new gradle plugin#39
Merged
Conversation
SimonIT
suggested changes
Nov 2, 2024
Member
SimonIT
left a comment
SimonIT
left a comment
There was a problem hiding this comment.
Unless I'm overseeing something, isn't
java {
withSourcesJar()
withJavadocJar()
}missing? Especially gwt won't work without it
MrStahlfelge
requested changes
Dec 18, 2024
Member
MrStahlfelge
left a comment
MrStahlfelge
left a comment
There was a problem hiding this comment.
- readme.md information to build from source does not apply any more, please change
gradlew test:html:superdevdoes not work
Contributor
Author
|
I think I addressed all issues |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'maven' publishing plugin is deprecated since gradle 5 and was removed in newer versions:
https://docs.gradle.org/current/userguide/upgrading_version_5.html
This pr upgrades the publishing process to use the new 'maven-publish' plugin.
Due to some generic issues I encountered when testing locally, I upgraded gradle in the same run to 7.3.3 which resolved them.