Skip to content

Added a spatial index to the overlayng polygonbuilder #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbaston merged 3 commits into from
Jan 17, 2026
+12 −2
Merged

Added a spatial index to the overlayng polygonbuilder #1379

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd35ea9
added a spatial index to the overlayng polygonbuilder
arriopolis Jan 16, 2026
50c7d5a
Updated spelling.
arriopolis Jan 16, 2026
a571213
reuse spatial filter result vector
arriopolis Jan 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/operation/overlayng/PolygonBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,21 @@ PolygonBuilder::assignHoles(OverlayEdgeRing* shell, const std::vector<OverlayEdg
void
PolygonBuilder::placeFreeHoles(const std::vector<OverlayEdgeRing*>& shells, const std::vector<OverlayEdgeRing*> & freeHoles) const
{
// TODO: use a spatial index to improve performance
// build spatial index
index::strtree::TemplateSTRtree<OverlayEdgeRing*> index;
for (auto& shell : shells) {
index.insert(*shell->getRingPtr()->getEnvelopeInternal(), shell);
}

std::vector<OverlayEdgeRing*> shellListOverlaps;
for (OverlayEdgeRing* hole : freeHoles) {
// only place this hole if it doesn't yet have a shell
if (hole->getShell() == nullptr) {
OverlayEdgeRing* shell = hole->findEdgeRingContaining(shells);
// get list of overlapping shells
shellListOverlaps.clear();
index.query(*hole->getRingPtr()->getEnvelopeInternal(), shellListOverlaps);

OverlayEdgeRing* shell = hole->findEdgeRingContaining(shellListOverlaps);
// only when building a polygon-valid result
if (isEnforcePolygonal && shell == nullptr) {
throw util::TopologyException("unable to assign free hole to a shell", hole->getCoordinate());
Expand Down
Loading