Add content for hole punching#200
Merged
Merged
Conversation
mxinden
reviewed
Sep 27, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
A couple of comments. Thanks for working on this @DannyS03!
Co-authored-by: Marten Seemann <martenseemann@gmail.com> Co-authored-by: Max Inden <mail@max-inden.de>
Contributor
Author
|
Thank you for the suggestions @mxinden @marten-seemann! They have been incorporated and left some notes on some. |
p-shahi
approved these changes
Oct 13, 2022
Member
p-shahi
left a comment
p-shahi
left a comment
There was a problem hiding this comment.
lgtm pending final review from others.
Contributor
Author
|
@marten-seemann seeing we're okay with merging with the current diagrams, great if you could provide a final review. |
Member
|
@DannyS03 let's also host the diagrams in this repo (not on imgur) |
Contributor
Author
|
Note on assets: "publish/subscribe" are also moved under "assets" here. |
Member
|
If no qualms, let's merge this by tomorrow e.o.d. |
Contributor
Author
|
checking here @marten-seemann for any qualms. |
Contributor
Author
|
🛳️? |
Member
🚢 it 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Latest preview
Please view the latest preview here.