feat: webrtc#264
Merged
Merged
Conversation
p-shahi
reviewed
Dec 5, 2022
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
mxinden
reviewed
Dec 14, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thanks for writing this up Danny.
I am not sure what the target audience is here. My intuition tells me that this would be too detailed for a libp2p user.
salmad3
added
change request
Co-authored-by: Max Inden <mail@max-inden.de>
marten-seemann
previously requested changes
Dec 15, 2022
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
Structure-wise, it would be nice to have the motivation for WebRTC at the top, not at the bottom of the document.
salmad3
added
ready for review
Contributor
Author
|
thanks @mxinden and @marten-seemann, feedback has been incorporated. |
2 tasks
mxinden
reviewed
Jan 4, 2023
Co-authored-by: Max Inden <mail@max-inden.de>
Co-authored-by: Max Inden <mail@max-inden.de>
3 tasks
p-shahi
requested changes
Jan 24, 2023
salmad3
added
change request
p-shahi
reviewed
Jan 24, 2023
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
Co-authored-by: Prithvi Shahi <50885601+p-shahi@users.noreply.github.com>
salmad3
added
ready for review
p-shahi
approved these changes
Jan 25, 2023
Member
p-shahi
left a comment
p-shahi
left a comment
There was a problem hiding this comment.
looks ok to me, the others should approve before merging
mxinden
approved these changes
Jan 27, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Last couple of comments. I am in favor of merging here afterwards. Thanks @DannyS03 for the work.
Contributor
Author
|
Thank you for the reviews and efforts folks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Latest preview
Please view the latest Fleek preview here.