fix(provider/keystore): protect keystore size during reset#1227
Merged
guillaumemichel merged 3 commits intomasterfrom Feb 11, 2026
Merged
fix(provider/keystore): protect keystore size during reset#1227guillaumemichel merged 3 commits intomasterfrom
guillaumemichel merged 3 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if keys were added to the keystore while
KeyChanFuncis called (duringResettableKeystorereset), adding keys to the alternate datastore didn't happen atomically, resulting in the same key that could be added multiple times (which isn't a problem in itself), leading to a wrong keystore size increase.Added a mutex to protect the alternate datastore from concurrent writes during reset, to keep a correct keystore size.
The keystore size corresponds to the number of CIDs scheduled in
ipfs provide stat.Also added logging to flag
ResettableKeystorereset events.