Enhance handleNewMessage Server Mode Logging: Convert Error Logs to Debug Level#860
Merged
guillaumemichel merged 1 commit intolibp2p:masterfrom Aug 10, 2023
Merged
Conversation
GheisMohammadi
requested review from
a team and
guillaumemichel
as code owners
MarcoPolo
approved these changes
Aug 10, 2023
guillaumemichel
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the handleNewMessage function exclusively processes messages in server mode, generating error logs and returning false for non-server mode cases. This leads to a repetitive logging of this error message whenever the node isn't in server mode:
ignoring incoming dht message while not in server modeThis PR enhances the function by elevating the error log to the debug level.