chore: add check for dscore < dhi and bootstrap params#643
Merged
MarcoPolo merged 1 commit intolibp2p:masterfrom Sep 15, 2025
Merged
chore: add check for dscore < dhi and bootstrap params#643MarcoPolo merged 1 commit intolibp2p:masterfrom
MarcoPolo merged 1 commit intolibp2p:masterfrom
Conversation
Contributor
|
thanks! |
Contributor
|
Thinking about this more, it's actually an error to set Dscore > Dhi. Dhi is our high watermark for peers in the mesh, and Dscore specifies how many high scoring peers are kept. By setting Dscore > Dhi you try to place keep more peers in your mesh than your hi watermark. You probably want to set Dscore to 0 for the bootstrapper case. Do you mind changing the validation to error if Dscore > Dhi? |
dozyio
changed the title
Contributor
Author
|
Thanks Marco - yeah that makes sense. Removed the fix, added a few bits the validation. |
and adjust validation for bootstrapper case
MarcoPolo
force-pushed
the
fix/d0-out-of-bounds-fix
branch
from
78887ab to
ef33e10
Compare
MarcoPolo
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was getting an out-of-bounds panic when running as a bootstrapper (D=D_lo=D_hi=D_out=0) https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#recommendations-for-network-operators.
Also added an early return to the new gossipsub validation to bootstrapper case.