swarm: fix Unwrap for DialError, implement Unwrap for TransportError#2437
Merged
marten-seemann merged 1 commit intomasterfrom Aug 25, 2023
Merged
swarm: fix Unwrap for DialError, implement Unwrap for TransportError#2437marten-seemann merged 1 commit intomasterfrom
marten-seemann merged 1 commit intomasterfrom
Conversation
sukunrt
force-pushed
the
sukun/dial-error
branch
from
c4eddd4 to
2342667
Compare
sukunrt
force-pushed
the
sukun/dial-error
branch
2 times, most recently
from
4dbd9ce to
4d5b0c9
Compare
marten-seemann
requested changes
Jul 19, 2023
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
There was a change in Go 1.20 that allows wrapping multiple errors. Should we use that new API?
We could simply wait until we drop Go 1.19 in a month, then we don't need to deal with any build flags now.
Member
Author
|
I don't mind waiting. This is not blocking anything. |
Contributor
|
We can still get it into the next release. v0.30 won't happen before the Go 1.21 transition (quic-go forces us to do so, if we want to include v0.37). |
sukunrt
force-pushed
the
sukun/dial-error
branch
from
4d5b0c9 to
5b022e5
Compare
sukunrt
removed
the
status/blocked
sukunrt
force-pushed
the
sukun/dial-error
branch
from
5b022e5 to
e63a025
Compare
Contributor
sukunrt
force-pushed
the
sukun/dial-error
branch
from
e63a025 to
5d41d7f
Compare
marten-seemann
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2436
Depends on #2460 #2461
Blocked on go1.21 release.