swarm: fix recursive resolving of DNS multiaddrs#2564
Merged
marten-seemann merged 2 commits intomasterfrom Oct 25, 2023
Merged
Conversation
feb3779 to
3695e19
Compare
Contributor
Author
|
The code works, but I should add a test case before we merge this. |
sukunrt
reviewed
Sep 12, 2023
Member
sukunrt
left a comment
There was a problem hiding this comment.
This change looks fine to me. But should https://github.com/libp2p/go-libp2p/blob/master/p2p/transport/websocket/websocket.go#L139 ignore dnsaddr addresses since the actual host will be obtained after resolving the dnsaddr
Contributor
|
Just smoked-tested it with (see the |
3695e19 to
a7c46cb
Compare
Contributor
Author
|
I added a test case, and linked the original issue. |
sukunrt
approved these changes
Oct 25, 2023
cce6b5b to
052bcde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.