Skip to content

chore: drop support for go1.20 #2708

Merged
sukunrt merged 5 commits intomasterfrom
ci-1-22
Feb 18, 2024
Merged

chore: drop support for go1.20 #2708
sukunrt merged 5 commits intomasterfrom
ci-1-22

Conversation

@sukunrt
Copy link
Copy Markdown
Member

@sukunrt sukunrt commented Feb 16, 2024

No description provided.

@sukunrt sukunrt changed the title ci: run for go1.22 chore: drop support for go1.20 Feb 16, 2024
@sukunrt sukunrt marked this pull request as ready for review February 16, 2024 17:58
Copy link
Copy Markdown
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, go 1.20 still "works", it'll just use a slower sha implementation. Which is fine, IMO.

@@ -10,9 +10,10 @@ import (
"io"
"math/big"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -8,9 +8,10 @@ import (
"errors"
"io"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -5,11 +5,12 @@ import (
"fmt"
"testing"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -10,10 +10,11 @@ import (
"runtime/debug"
"time"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants