Add missing log for failed GC record unmarshalling in purgeStore()#3273
Merged
MarcoPolo merged 1 commit intolibp2p:masterfrom Apr 21, 2025
vipocenka:fix/update
Merged
Add missing log for failed GC record unmarshalling in purgeStore()#3273MarcoPolo merged 1 commit intolibp2p:masterfrom vipocenka:fix/update
purgeStore()#3273MarcoPolo merged 1 commit intolibp2p:masterfrom
vipocenka:fix/update
Conversation
MarcoPolo
approved these changes
Apr 18, 2025
Collaborator
MarcoPolo
left a comment
There was a problem hiding this comment.
Thanks :) are you using the pstoreds package by any chance?
Contributor
Author
|
@MarcoPolo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces a
// TODOcomment with an actual log statement in thepurgeStore()method of thedsAddrBookGc:Change summary:
log.Warnfwhenproto.Unmarshalfails during garbage collection: