fix: Ensure tcpGatedMaListener wrapping on both metrics and non-metri…#3275
Merged
sukunrt merged 1 commit intolibp2p:masterfrom May 26, 2025
Merged
fix: Ensure tcpGatedMaListener wrapping on both metrics and non-metri…#3275sukunrt merged 1 commit intolibp2p:masterfrom
sukunrt merged 1 commit intolibp2p:masterfrom
Conversation
sukunrt
approved these changes
May 16, 2025
Member
|
Thanks @GarmashAlex. Apologies for the very late review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cs paths
This commit fixes the TCP listener wrapping issue identified in the TODO comment.
Previously, the tcpGatedMaListener was only being applied when metrics were
enabled, but it should be applied consistently on both paths.
The fix ensures that the TCP-specific configurations (such as linger and keepalive
settings) are always applied regardless of whether metrics are enabled, by:
This change maintains the same functionality but makes behavior consistent
between metrics-enabled and metrics-disabled configurations, resolving the TODO.