Merged
Conversation
sukunrt
force-pushed
the
sukun/remove-certhasher
branch
from
4d04960 to
ac162ab
Compare
sukunrt
force-pushed
the
sukun/remove-certhasher
branch
from
ac162ab to
f05a92c
Compare
MarcoPolo
reviewed
Jul 28, 2025
Comment on lines
+965
to
+968
| // AddCertHashes adds certificate hashes to relevant transport addresses, if there | ||
| // are no certhashes already present on the method. It mutates `listenAddrs`. | ||
| // This method is useful for adding certhashes to public addresses discovered | ||
| // via identify, nat mapping, or provided by the user. |
Collaborator
There was a problem hiding this comment.
This comment needs some editing. Maybe:
Suggested change
| // AddCertHashes adds certificate hashes to relevant transport addresses, if there | |
| // are no certhashes already present on the method. It mutates `listenAddrs`. | |
| // This method is useful for adding certhashes to public addresses discovered | |
| // via identify, nat mapping, or provided by the user. | |
| // AddCertHashes mutates listenAddrs. It adds applicable certificate hashes to | |
| // the multiaddrs. It will not modify a multiaddr if it already contains a | |
| // certificate hash. This method is useful for adding certhashes to public | |
| // addresses discovered via identify, nat mapping, or provided by the user. |
Member
Author
There was a problem hiding this comment.
Missed this. I'll open a separate PR.
MarcoPolo
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simplified idea here is: if we can listen on the addr, we should try adding certhashes to the addr.
This removes dependency on WebTransport and WebRTC Transports.