Skip to content

p2p/autorelay: use reservation addrs, remove addrsplosion#3376

Open
sashass1315 wants to merge 3 commits intolibp2p:masterfrom
sashass1315:TODO
Open

p2p/autorelay: use reservation addrs, remove addrsplosion#3376
sashass1315 wants to merge 3 commits intolibp2p:masterfrom
sashass1315:TODO

Conversation

@sashass1315
Copy link
Copy Markdown

  • Updated getCircuitAddrs to build /p2p-circuit addrs from rsvp.Addrs
  • Inlined isRelayAddr into relay_finder.go
  • Removed cleanupAddressSet and deleted addrsplosion.go + its tests
  • Dropped obsolete heuristic in favor of relay-provided addresses

@MarcoPolo
Copy link
Copy Markdown
Collaborator

Can you please share the motivation for this change?

@sashass1315
Copy link
Copy Markdown
Author

Can you please share the motivation for this change?

// TODO: Remove this, we don't need this. The current method tries to select the
// best address for the relay. Instead we should rely on the addresses provided by the
// relay in response to the reservation request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants