resource-manager: clarify connLimiter behavior and add WithDisableConnLimits option#3453
Open
alienx5499 wants to merge 2 commits intolibp2p:masterfrom
Open
resource-manager: clarify connLimiter behavior and add WithDisableConnLimits option#3453alienx5499 wants to merge 2 commits intolibp2p:masterfrom
alienx5499 wants to merge 2 commits intolibp2p:masterfrom
Conversation
Collaborator
|
Related to #3438 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #3431 by clarifying the behavior of
InfiniteLimitsand the connection limiter (connLimiter) in the resource manager documentation.Problem
When using
InfiniteLimitsto disable resource manager limits, users expected all limits to be disabled. However, theconnLimiteroperates independently and still enforces default limits:This was not documented, leading to confusion when connections were still being limited despite using
InfiniteLimits.Changes
1. Documentation Updates (
README.md)InfiniteLimitsdoesn't disableconnLimiterWithLimitPerSubnetWithNetworkPrefixLimitWithDisableConnLimits()option2. New Functionality (
conn_limiter.go)WithDisableConnLimits()option for easily disabling connection limits3. Tests (
conn_limiter_test.go)TestWithDisableConnLimitsto verify the new option works correctlyUsage Examples
Disabling all limits including connLimiter:
Customizing per-subnet limits:
Setting network-specific limits:
Testing
All tests pass:
TestWithDisableConnLimitsverifies the new functionalityRelated Issue
Fixes #3431
Checklist