Improve peer ID parse error context and wrap error#3484
Open
bobsingh-dev wants to merge 1 commit intolibp2p:masterfrom
Open
Improve peer ID parse error context and wrap error#3484bobsingh-dev wants to merge 1 commit intolibp2p:masterfrom
bobsingh-dev wants to merge 1 commit intolibp2p:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve error wrapping and include the peer ID input value in the error message to improve debugging.
Why was this needed?
Including the input improves observability when diagnosing invalid peer IDs. Using %w preserves the error chain.
How was this tested?
go test ./...