feat: add type stubs for miniupnpc #1245
Open
GautamBytes wants to merge 2 commits intolibp2p:mainfrom
Open
Conversation
Signed-off-by: Gautam Manchandani <gautammanch@Gautams-MacBook-Air.local>
Signed-off-by: Gautam Manchandani <gautammanch@Gautams-MacBook-Air.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
The type checker (pyrefly) failed when importing miniupnpc because it is a C extension without native type stubs. A previous quick-fix (PR #1010) used a # type: ignore comment to bypass the error, but this did not provide proper type safety or IDE support for developers.
Issue #1009
How was it fixed?
Following the long-term solution suggested in the issue, I implemented the following changes:
To-Do
[x] Clean up commit history
[x] Add or update documentation related to these changes
[x] Add entry to the release notes