fix(webrtc): Don't append /p2p to listen addresses#3154
Merged
mergify[bot] merged 2 commits intoNov 23, 2022
Merged
Conversation
to align with all other transports, which don't include `/p2p/..` in their reported addresses. Refs libp2p#2622 (comment)
thomaseizinger
changed the title
/p2p to listen addresses
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thanks!
I think you have to adjust the tests too to append it there again!
Contributor
Author
|
The tests are passing for me locally. CI fails with "Error: No available baseline versions for libp2p-webrtc@0.1.0-alpha". Not sure what that means. |
Contributor
That is because of #3141. We will need to adjust the version to actually be greater than what is released. |
Contributor
Interesting, I thought I added the appending of the |
thomaseizinger
approved these changes
Nov 23, 2022
Member
|
It seems like the Testground build of the commits on this pull request fails: I am guessing this is due to the fact that this pull request is on a fork and not on the main repository? //CC @thomaseizinger |
Member
|
I have a suspicion:
|
Contributor
Author
|
It's a bit weird that build is failing for external contributors 😕 Feel free to cherry-pick this commit! As long as the changes are merged, I'm happy. |
mxinden
added a commit
to mxinden/test-plans
that referenced
this pull request
Nov 23, 2022
When building the `master` image we would previously mistakingly set the ref to the PR commit hash. This surfaced when testing a pull request from a fork. `master` would be pointed at the forks HEAD commit hash, but not the fork URL. Thus the build could not find the commit and would fail. See libp2p/rust-libp2p#3154
mxinden
added a commit
to libp2p/test-plans
that referenced
this pull request
Nov 23, 2022
When building the `master` image we would previously mistakingly set the ref to the PR commit hash. This surfaced when testing a pull request from a fork. `master` would be pointed at the forks HEAD commit hash, but not the fork URL. Thus the build could not find the commit and would fail. See libp2p/rust-libp2p#3154
mxinden
approved these changes
Nov 23, 2022
codemaestro64
pushed a commit
to codemaestro64/test-plans
that referenced
this pull request
Oct 28, 2025
When building the `master` image we would previously mistakingly set the ref to the PR commit hash. This surfaced when testing a pull request from a fork. `master` would be pointed at the forks HEAD commit hash, but not the fork URL. Thus the build could not find the commit and would fail. See libp2p/rust-libp2p#3154
github-actions Bot
pushed a commit
to py-libp2p-runners/test-plans
that referenced
this pull request
May 12, 2026
When building the `master` image we would previously mistakingly set the ref to the PR commit hash. This surfaced when testing a pull request from a fork. `master` would be pointed at the forks HEAD commit hash, but not the fork URL. Thus the build could not find the commit and would fail. See libp2p/rust-libp2p#3154
github-actions Bot
pushed a commit
to py-libp2p-runners/test-plans
that referenced
this pull request
May 12, 2026
When building the `master` image we would previously mistakingly set the ref to the PR commit hash. This surfaced when testing a pull request from a fork. `master` would be pointed at the forks HEAD commit hash, but not the fork URL. Thus the build could not find the commit and would fail. See libp2p/rust-libp2p#3154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This aligns with what other transports do.
Related: #2622 (comment).