Merged
Conversation
Adds a basic Node.js peer with a terminal user interface. Lifts some code from the existing js-peer. Doesn't support DMs (yet).
2color
reviewed
Apr 22, 2025
2color
reviewed
Apr 22, 2025
| <View> | ||
| <Peer key={libp2p?.peerId?.toString()} peer={libp2p?.peerId} self={true} children={[]} /> | ||
| {subscribers.map((p) => ( | ||
| <Peer key={p.toString()} peer={p} self={false} children={[]} /> |
Contributor
There was a problem hiding this comment.
Do you know why the empty array children prop is necessary here? Is this a react-curse thing, because I get an error thrown if removed.
Member
Author
There was a problem hiding this comment.
I think it might be a bug in react-curse
Contributor
There was a problem hiding this comment.
Let's maybe add a comment about this?
Member
Author
There was a problem hiding this comment.
Done & have linked to a fix PR'd to react-curse
2color
approved these changes
Apr 22, 2025
Contributor
|
Very neat! Thanks for the PR |
Closed
dozyio
pushed a commit
to dozyio/universal-connectivity
that referenced
this pull request
Sep 7, 2025
Adds a basic Node.js peer with a terminal user interface. Lifts some code from the existing js-peer. Doesn't support DMs or dialing peers directly (yet). Fixes libp2p#214 --------- Co-authored-by: Daniel N <2color@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a basic Node.js peer with a terminal user interface.
Lifts some code from the existing js-peer. Doesn't support DMs or dialing peers directly (yet).
Fixes #214