Update git protocol doc and reformat core.rs#17
Merged
Conversation
Signed-off-by: Quanyi Ma <eli@patch.sh>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates import organization in the protocol core module and adds comprehensive documentation for Git protocol version evolution. The changes reorganize imports to follow Rust conventions (std imports first) and replace relative imports with absolute crate paths, while also documenting the differences between protocol versions v0, v1, and v2 with migration guidance.
- Reformatted imports in
core.rsto follow standard ordering conventions - Added detailed protocol version comparison table and command documentation
- Included migration recommendations for implementers and the git-internal library
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/protocol/core.rs | Reorganized imports to follow std-first convention and changed relative imports to absolute crate paths |
| docs/GIT_PROTOCOL_GUIDE.md | Added comprehensive protocol version comparison (v0/v1/v2), command documentation, and migration guidance |
benjamin-747
approved these changes
Oct 27, 2025
genedna
pushed a commit
to genedna/git-internal
that referenced
this pull request
Mar 15, 2026
Update git protocol doc and reformat core.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.