Skip to content

fix(encode): 32-bit safe pack header check #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genedna merged 1 commit into from
Jan 4, 2026
Merged

fix(encode): 32-bit safe pack header check #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/internal/pack/encode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ fn encode_header(object_number: usize) -> Vec<u8> {
0, 0, 0, 2, // generates version 2 only.
];
assert_ne!(object_number, 0); // guarantee self.number_of_objects!=0
assert!(object_number < (1 << 32));
assert!(object_number <= u32::MAX as usize);
//TODO: GitError:numbers of objects should < 4G ,
result.append((object_number as u32).to_be_bytes().to_vec().as_mut()); // to 4 bytes (network byte order aka. big-endian)
result
Expand Down