Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses correctness issues in pywasm’s execution semantics and numeric encoding, motivated by Issue #101 (Go wasip1 modules crashing due to incorrect frame/label handling during calls).
Changes:
- Fix the function-call label’s
frameindex so branches/returns unwind to the correct call frame. - Adjust
f32serialization to pack values after rounding tofloat32(viactypes.c_float), avoiding overflow errors fromstruct.pack.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pywasm/core.py |
Corrects the label frame index for internal function calls to prevent frame/label mismatches during control-flow unwinding. |
pywasm/arith.py |
Ensures f32 values are rounded to float32 before packing into bytes to avoid packing overflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #101