Skip to content

refactor: Add Python type annotations wherever appropriate#269

Merged
kavishdevar merged 2 commits into
librepods-org:mainfrom
mikomikotaishi:main
Nov 19, 2025
Merged

refactor: Add Python type annotations wherever appropriate#269
kavishdevar merged 2 commits into
librepods-org:mainfrom
mikomikotaishi:main

Conversation

@mikomikotaishi

@mikomikotaishi mikomikotaishi commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

This pull request:

  • Moves Colors and ColorFormatter to a separate file, rather than repeating it three times
  • Adds Python type annotations wherever/whenever appropriate
  • Organises import statements alphabetically, and adds from import statements wherever appropriate for name simplification
  • Replaces string concatenations with fstrings when possible
  • Replaces if/else with match

@mikomikotaishi mikomikotaishi changed the title Add Python type annotations wherever appropriate refactor: Add Python type annotations wherever appropriate Nov 18, 2025
@kavishdevar

kavishdevar commented Nov 19, 2025

Copy link
Copy Markdown
Member

did not expect to see any changes in the hearing aid code (i just made it to experiment), but thanks!

@kavishdevar kavishdevar merged commit 0a608af into librepods-org:main Nov 19, 2025
kavishdevar pushed a commit that referenced this pull request May 15, 2026
* Add Python type annotations wherever appropriate

* Might as well annotate this too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants