media: correct conversational awareness state handling#302
Merged
kavishdevar merged 1 commit intoNov 22, 2025
Conversation
Member
|
what anc mode are you in? a lower number (1 or 2) is usually sent when a conversation is detected. |
Fix incorrect detection of conversational awareness events. The previous implementation treated all non-0x01 packets as "disabled", which caused wrong behavior when the user manually enabled/disabled the feature or when voice-end events were received. Adds full decoding for packet types: - 0x01 → voice detected - 0x06/others → voice ended - 0x08 → feature disabled - 0x09 → feature enabled Signed-off-by: ozan956 <ozandurgut.2001@hotmail.com>
ozan956
force-pushed
the
fix-conversational-awareness
branch
from
0c2374b to
8f59499
Compare
ozan956
changed the title
ozan956
changed the title
Contributor
Author
|
Yes @kavishdevar, you are right. But i think problem is something different. I did some tests and mainly, there are 4 output for conversational awareness. I have listed them in the commit but they are:
So previously, code outputs 'Conversational awareness disabled' everything except 0x01. However, this is not the correct information to log I think. I just added a block to fix this. |
Member
|
yup, the 'enabled/disabled' is a bit misleading. thank you! |
kavishdevar
pushed a commit
that referenced
this pull request
May 15, 2026
media: correct AirPods conversational awareness state handling Fix incorrect detection of conversational awareness events. The previous implementation treated all non-0x01 packets as "disabled", which caused wrong behavior when the user manually enabled/disabled the feature or when voice-end events were received. Adds full decoding for packet types: - 0x01 → voice detected - 0x06/others → voice ended - 0x08 → feature disabled - 0x09 → feature enabled Signed-off-by: ozan956 <ozandurgut.2001@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AirPods conversational awareness packets use 0x09 to indicate that the feature is enabled, not 0x01. The previous implementation always decoded the state as disabled because data[9] never equaled 0x01.