Migrate wrapper testnet and add custom pool factory#150
Merged
Conversation
…li into feature/si-2336-defi-wrapper-cli-scope
DiRaiks
previously approved these changes
Jan 12, 2026
DiRaiks
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates and refactorings to the STV-STETH pool ABI, related contract commands, and associated scripts. The main focus is on renaming and replacing certain pool configuration parameters to improve clarity, as well as adding new options for pool creation and expanding error handling. Below are the most important changes grouped by theme.
ABI and Pool Configuration Updates
forcedRebalanceThresholdBPandreserveRatioBPwithpoolForcedRebalanceThresholdBPandpoolReserveRatioBPin theStvStETHPoolAbiand updated all references in code to use the new names for improved clarity and consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]rebalanceExceedingMintedStethSharesand error typeInsufficientExceedingSharesto support new pool operations and error handling. [1] [2]forcedRebalanceThresholdBP,reserveRatioBP, and error typeArraysLengthMismatchas they are now obsolete. [1] [2] [3]Pool Creation Command Enhancements
allowListManager,mintingEnabled,strategyFactory, andstrategyFactoryDeployBytes, and refactored option definitions for consistency and reusability. [1] [2] [3] [4] [5]allowListManagerand other new options in confirmation prompts and payloads, defaulting tozeroAddresswhen not provided. [1] [2] [3] [4]Miscellaneous Improvements
allowlistEnabledtoallowListEnabledfor consistency across the codebase.create-pool-customcommand for deploying custom pools with extended configuration options.These changes collectively improve naming consistency, extend pool creation flexibility, and enhance error handling and logging throughout the STV-STETH pool codebase.### Description
Demo
Code review notes
Testing notes
Checklist: