Skip to content

Migrate wrapper testnet and add custom pool factory#150

Merged
DiRaiks merged 5 commits intodevelopfrom
feature/si-2336-defi-wrapper-cli-scope
Jan 15, 2026
Merged

Migrate wrapper testnet and add custom pool factory#150
DiRaiks merged 5 commits intodevelopfrom
feature/si-2336-defi-wrapper-cli-scope

Conversation

@Jeday
Copy link
Contributor

@Jeday Jeday commented Jan 12, 2026

This pull request introduces several updates and refactorings to the STV-STETH pool ABI, related contract commands, and associated scripts. The main focus is on renaming and replacing certain pool configuration parameters to improve clarity, as well as adding new options for pool creation and expanding error handling. Below are the most important changes grouped by theme.

ABI and Pool Configuration Updates

  • Replaced forcedRebalanceThresholdBP and reserveRatioBP with poolForcedRebalanceThresholdBP and poolReserveRatioBP in the StvStETHPoolAbi and updated all references in code to use the new names for improved clarity and consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]
  • Added new ABI functions: rebalanceExceedingMintedStethShares and error type InsufficientExceedingShares to support new pool operations and error handling. [1] [2]
  • Removed the ABI function forcedRebalanceThresholdBP, reserveRatioBP, and error type ArraysLengthMismatch as they are now obsolete. [1] [2] [3]

Pool Creation Command Enhancements

  • Added new command-line options for pool creation: allowListManager, mintingEnabled, strategyFactory, and strategyFactoryDeployBytes, and refactored option definitions for consistency and reusability. [1] [2] [3] [4] [5]
  • Updated pool creation logic to include allowListManager and other new options in confirmation prompts and payloads, defaulting to zeroAddress when not provided. [1] [2] [3] [4]

Miscellaneous Improvements

  • Fixed typo in event data logging from allowlistEnabled to allowListEnabled for consistency across the codebase.
  • Added a new create-pool-custom command for deploying custom pools with extended configuration options.

These changes collectively improve naming consistency, extend pool creation flexibility, and enhance error handling and logging throughout the STV-STETH pool codebase.### Description

Demo

Code review notes

Testing notes

Checklist:

  • Checked the changes locally.
  • Created/updated unit tests.
  • Created/updated README.md.

@Jeday Jeday requested a review from a team as a code owner January 12, 2026 17:53
@Jeday Jeday changed the title Migrate wrapper testnet and add custom Migrate wrapper testnet and add custom pool factory Jan 12, 2026
@Jeday Jeday changed the title Migrate wrapper testnet and add custom pool factory [WIP]Migrate wrapper testnet and add custom pool factory Jan 12, 2026
@Jeday Jeday changed the title [WIP]Migrate wrapper testnet and add custom pool factory Migrate wrapper testnet and add custom pool factory Jan 12, 2026
DiRaiks
DiRaiks previously approved these changes Jan 12, 2026
@DiRaiks DiRaiks merged commit b75fc0a into develop Jan 15, 2026
1 check passed
@DiRaiks DiRaiks deleted the feature/si-2336-defi-wrapper-cli-scope branch January 15, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants