Merged
Conversation
c00cc3c to
05f686a
Compare
05f686a to
4e3342e
Compare
* remove vcpkg_helper.cmake * fix build instruction in README
Contributor
|
diff is failing to build due to llvm version mismatch, should get resolved after this gets merged |
surovic
approved these changes
Dec 22, 2022
Contributor
surovic
left a comment
There was a problem hiding this comment.
Just to be sure, the changes in various printers are straight copy-pastes from clang, right? Otherwise LGTM.
Collaborator
Author
|
All copy-pastes. I want to get rid of the custom printer when we update to LLVM16, but that might require using PASTA, which requires a patched Clang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.