Conversation
|
See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3313437158 Detailsfizzbuzz.bctypedefs_of_typedefs.bcswitch_loop.bcfunc_cond_zero_arg.bcfcmp.bcconflicting_names.bcstruct.bcissue_183_literal_structs.bczeroinit.bcissue_127_uint128_t_lit.bcstruct_swap.bcglobal_using_function_decl.bcinit_list.bcreg_test_structure_fields.bcret0.bcgoto_loop.bcbool.bcbitops.bccast.bcnullptr.bcnested_struct.bcarray_swap.bcbinops.bcbitmask.bcloop.bcfloat.bcvectors.bcfuncptr.bcinttoptr.bcshort.bctrunc.bcissue_4.bcconflicting_global.bcissue_123_uint128_t.bcfizzbuzz_stateful.bcissue_94_strncmp.bczext.bcbyval_struct.bcnested_while.bc--- /dev/fd/63 2022-10-24 14:19:07.518746030 +0000
+++ /dev/fd/62 2022-10-24 14:19:07.522746094 +0000
@@ -18,14 +18,14 @@
printf("loop1 x: %d\n", var1);
}
}
- if ((int)var1 >= 20 || (int)var1 <= 10) {
+ if ((int)var1 <= 10 || (int)var1 >= 20) {
while ((int)var1 < 20)
{
var1 = var1 + 1U;
printf("loop2 x: %d\n", var1);
}
}
- if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
+ if ((int)var1 >= 20 && ((int)var1 <= 10 || (int)var1 >= 20)) {
return var0;
}
}func_cond_two_arg.bcassert.bcswitch.bcbranch.bctemplate_parameter_pack.bcbyval_tail_nogep.llbyval_tail_gep.ll |
|
See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3314458380 Detailsfizzbuzz.bc--- /dev/fd/63 2022-10-24 16:32:56.002768545 +0000
+++ /dev/fd/62 2022-10-24 16:32:56.002768545 +0000
@@ -11,7 +11,7 @@
var1 = 0U;
while ((int)var1 < 30)
{
- if ((int)var1 % 3 != 0U || !((int)var1 % 3 != 0U || (int)var1 % 5 == 0U)) {
+ if (!((int)var1 % 5 == 0U || (int)var1 % 3 != 0U) || (int)var1 % 3 != 0U) {
if ((int)var1 % 3 != 0U) {
if ((int)var1 % 5 != 0U) {
printf("%d\n", var1);typedefs_of_typedefs.bcswitch_loop.bcfunc_cond_zero_arg.bcfcmp.bcconflicting_names.bcstruct.bcissue_183_literal_structs.bczeroinit.bcissue_127_uint128_t_lit.bcstruct_swap.bcglobal_using_function_decl.bcinit_list.bcreg_test_structure_fields.bcret0.bcgoto_loop.bcbool.bcbitops.bccast.bcnullptr.bcnested_struct.bcarray_swap.bcbinops.bcbitmask.bcloop.bcfloat.bcvectors.bcfuncptr.bcinttoptr.bcshort.bctrunc.bcissue_4.bcconflicting_global.bcissue_123_uint128_t.bcfizzbuzz_stateful.bcissue_94_strncmp.bczext.bcbyval_struct.bcnested_while.bcfunc_cond_two_arg.bcassert.bcswitch.bcbranch.bctemplate_parameter_pack.bcbyval_tail_nogep.llbyval_tail_gep.ll |
|
See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3314492638 Detailsfizzbuzz.bctypedefs_of_typedefs.bcswitch_loop.bcfunc_cond_zero_arg.bcfcmp.bcconflicting_names.bcstruct.bcissue_183_literal_structs.bczeroinit.bcissue_127_uint128_t_lit.bcstruct_swap.bcglobal_using_function_decl.bcinit_list.bcreg_test_structure_fields.bcret0.bcgoto_loop.bcbool.bcbitops.bccast.bcnullptr.bcnested_struct.bcarray_swap.bcbinops.bcbitmask.bcloop.bcfloat.bcvectors.bcfuncptr.bcinttoptr.bcshort.bctrunc.bcissue_4.bcconflicting_global.bcissue_123_uint128_t.bcfizzbuzz_stateful.bcissue_94_strncmp.bczext.bcbyval_struct.bcnested_while.bc--- /dev/fd/63 2022-10-24 16:37:53.600835764 +0000
+++ /dev/fd/62 2022-10-24 16:37:53.600835764 +0000
@@ -18,14 +18,14 @@
printf("loop1 x: %d\n", var1);
}
}
- if ((int)var1 >= 20 || (int)var1 <= 10) {
+ if ((int)var1 <= 10 || (int)var1 >= 20) {
while ((int)var1 < 20)
{
var1 = var1 + 1U;
printf("loop2 x: %d\n", var1);
}
}
- if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
+ if ((int)var1 >= 20 && ((int)var1 <= 10 || (int)var1 >= 20)) {
return var0;
}
}func_cond_two_arg.bcassert.bcswitch.bcbranch.bctemplate_parameter_pack.bcbyval_tail_nogep.llbyval_tail_gep.ll |
|
See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3314555205 Detailsfizzbuzz.bctypedefs_of_typedefs.bcswitch_loop.bcfunc_cond_zero_arg.bcfcmp.bcconflicting_names.bcstruct.bcissue_183_literal_structs.bczeroinit.bcissue_127_uint128_t_lit.bcstruct_swap.bcglobal_using_function_decl.bcinit_list.bcreg_test_structure_fields.bcret0.bcgoto_loop.bcbool.bcbitops.bccast.bcnullptr.bcnested_struct.bcarray_swap.bcbinops.bcbitmask.bcloop.bcfloat.bcvectors.bcfuncptr.bcinttoptr.bcshort.bctrunc.bcissue_4.bcconflicting_global.bcissue_123_uint128_t.bcfizzbuzz_stateful.bcissue_94_strncmp.bczext.bcbyval_struct.bcnested_while.bcfunc_cond_two_arg.bcassert.bcswitch.bcbranch.bctemplate_parameter_pack.bcbyval_tail_nogep.llbyval_tail_gep.ll |
Contributor
Author
|
Should be passing most of checks, i think a few need some more work |
Collaborator
|
I think the AWS-related secrets can be removed |
Contributor
Author
|
Ah yeah, wasn't sure if we still wanted to upload the test artifacts to s3 |
Contributor
Author
|
AWS related secrets are DO spaces credentials that we upload artifacts to through their S3 compatible API |
frabert
approved these changes
Oct 24, 2022
| @@ -173,26 +139,3 @@ jobs: | |||
| AWS_ACCESS_KEY_ID: ${{ secrets.DO_SPACES_KEY_ID }} | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.