BOLT #2: bad update_fee after shutdown when all HTLCs cleared.#367
Merged
rustyrussell merged 1 commit intolightning:masterfrom Feb 5, 2018
Merged
Conversation
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Jan 30, 2018
See: lightning/bolts#367 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Feb 1, 2018
See: lightning/bolts#367 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
added a commit
to rustyrussell/lightning
that referenced
this pull request
Feb 2, 2018
See: lightning/bolts#367 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker
pushed a commit
to rustyrussell/lightning
that referenced
this pull request
Feb 2, 2018
See: lightning/bolts#367 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker
pushed a commit
to ElementsProject/lightning
that referenced
this pull request
Feb 2, 2018
See: lightning/bolts#367 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
cdecker
approved these changes
Feb 5, 2018
jimpo
reviewed
Feb 5, 2018
| HTLCs will be added or accepted. Once any HTLCs are cleared, the peer | ||
| may immediately begin closing negotiation, so we ban further updates | ||
| the commitment transaction (in particular, `update_fee` would be | ||
| possible otherwise). |
Collaborator
Author
There was a problem hiding this comment.
Thanks, fixed!
I got an unexpected update_fee message after `shutdown` exchange,
which is currently legal:
A: shutdown (no htlcs)
B: receive shutdown
B: reply with shutdown & closing_signed
A: send update_fee & commitment_signed
A: receive shutdown
Simplest to ban any updates (currently, just update_fee) from adding a
new commitment tx while we're at the end of shutdown.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
dont-send-feechange-at-end-of-shutdown
branch
from
ba03a76 to
5f998e5
Compare
Collaborator
Author
|
Merged as agreed at https://docs.google.com/document/d/1SSRsT0iyRv2XtdCBlRU6WttBO1POo7e9lQPsEiJacYY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got an unexpected update_fee message after
shutdownexchange,which is currently legal:
A: shutdown (no htlcs)
B: receive shutdown
B: reply with shutdown & closing_signed
A: send update_fee & commitment_signed
A: receive shutdown
Simplest to ban any updates (currently, just update_fee) from adding a
new commitment tx while we're at the end of shutdown.
Signed-off-by: Rusty Russell rusty@rustcorp.com.au